Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElectricJuicer #4191

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ElectricJuicer #4191

wants to merge 3 commits into from

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented May 16, 2024 •
edited
Loading

Approved suggestion #2560 discord

Description

Adding an ElectricJuicer so people aren't force to use the manual MultiBlock to get juicer, and can automate the process with cargo.

Proposed changes

Added on PostSetup a juicer recipe loader to a new machine called ElectricJuicer.
The new recipe is similar to the original multiblock, but requiring some electric motors, a battery and some other basic blocks.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte
ElectricJuicer
7758114 
Suggestion Slimefun#2560 discord
@Intybyte Intybyte requested a review from a team as a code owner May 16, 2024 13:34
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@J3fftw1
Copy link
Contributor

J3fftw1 commented May 18, 2024 •
edited
Loading

We previously denied a PR like this since it’s in one of the addons already I think

@JustAHuman-xD
Copy link
Contributor

Oh really? Anyone know what addon?

@Intybyte
Copy link
Contributor Author

We previously denied a PR like this since it’s in one of the addons already I think

Just because an addon adds it it isn't a good reason to not accept the PR man, someone a day made a mod for pistons in minecraft back in beta and mojang decided to add it to the main game. Never saw anyone whining about pistons xD

@Boomer-1
Copy link

As a general rule, core slimefun doesn't add items that addons have for obvious reasons. it's not to say it wouldn't happen, but it doesn't make sense to duplicate others work

@JustAHuman-xD
Copy link
Contributor

Can anyone say what addon this is in? If it's abandoned or unmaintained, something like that, I think that'd be justification enough for it being added to core slimefun.

@Boomer-1
Copy link

Boomer-1 commented Jun 3, 2024

i've not seen one that i can remember. i just checked the active addons and it's not there. the only other juicer i've seen is in fast machines

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: f9d5d7c

https://preview-builds.walshy.dev/download/Slimefun/4191/f9d5d7c0

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Intybyte
Copy link
Contributor Author

Could not find any addon that added a similar feauture, I have looked for quite a while

TheBusyBiscuit
TheBusyBiscuit previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea ✔️ Thanks!

...o/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/ElectricJuicer.java Show resolved Hide resolved
JustAHuman-xD
JustAHuman-xD previously approved these changes Aug 8, 2024
View reviewed changes
@Intybyte Intybyte dismissed stale reviews from JustAHuman-xD and TheBusyBiscuit via 5bcd79d August 31, 2024 07:35
JustAHuman-xD
JustAHuman-xD approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAHuman-xD JustAHuman-xD JustAHuman-xD approved these changes

@TheBusyBiscuit TheBusyBiscuit Awaiting requested review from TheBusyBiscuit

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Intybyte @J3fftw1 @JustAHuman-xD @Boomer-1 @TheBusyBiscuit